Skip to content

Don't show compliance dashboard drawer if link is clicked

What does this MR do?

This MR fixes the compliance dashboard drawer so when a user clicks on an MR row, it will open the drawer. But when a user clicks on a link within an MR row, the drawer is not opened.

Screenshots (strongly suggested)

Screen_Recording_2021-07-02_at_08.55.24

Setup & testing

This requires a GitLab Ultimate license to use

  1. Enable the feature flag: echo "Feature.enable(:compliance_dashboard_drawer)" | rails c
  2. Go to [HOST]/groups/[GROUP]/-/security/compliance_dashboard
  3. Check that MR's are shown, if they aren't then you may need to merge some in the group
  4. Check the MR's data appears and you can click on an MR row to toggle the drawer
  5. Check that you can click on links in the MR row and it won't toggle the drawer or change the open drawer data as it traverses to the new location

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #334980 (closed)

Edited by Robert Hunt

Merge request reports