Skip to content

Blob refactor: add blob delete modal

Samantha Ming requested to merge 333773-blob-header-delete-modal into master

What does this MR do?

MR Changes
!64666 (merged) Convert to button group and add delete button
this MR Add blob delete modal
TBD (Issue #335743 (closed)) Add validation directive to delete form

This MR adds a delete blob modal. It's part of the refactoring from HAML to Vue for the entire blob content > &5531 (closed).

Button Modal
image image

Here's the HAML file for reference:

  • app/views/projects/blob/_remove.html.haml
    • app/views/shared/_new_commit_form.html.haml

Testing Case

This feature is behind a feature flag, to turn on:

rails c

Feature.enable(: refactor_blob_viewer)
  1. Navigate to Repository > Files.
  2. Click on a file.

Deleting a file

After deleting a file in the same branch, you will get redirected back to the files page.

Modal Redirect to Files Page
image image

Deleting a file in a new merge request

When deleting a file in a new merge request. The deleted file will appear in the newly created branch and you will get redirected to the "Create MR" page.

Modal Redirect New MR Page
image image

Note

There is no new behavior that is introduced with this MR. We are simply moving the delete blob modal into Vue. Note, because we're still in the early stages of the refactoring, there are still missing components that have not migrated to Vue; hence, we're leaving the feature specs updates until the migration is at a more complete stage. This feature is behind a FF, so we have some safety net to work on this iteratively 💪

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #333773 (closed)

Edited by Samantha Ming

Merge request reports