Skip to content

Add license flag to status checks settings

What does this MR do?

This MR fixes a bug where non GitLab Ultimate customers are seeing an alert on project settings because Status checks is only available for GitLab Ultimate but is not being excluded from rendering.

Screenshots (strongly suggested)

Screenshot_2021-07-01_at_13.53.49

Setup & testing

  1. Enable the feature flag: echo "Feature.enable(:ff_external_status_checks)" | rails c
  2. Using an GitLab Ultimate license, go to [HOST]/[GROUP]/[PROJECT]/edit#js-merge-request-settings and scroll down to Status checks (it should be visible)
  3. Swap to a GitLab Premium license and refresh the page, Status checks should no longer appear or throw alerts

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #334981 (closed)

Edited by Robert Hunt

Merge request reports

Loading