Fix default dependency list sort order icon
What does this MR do?
This MR fixes the default sort order for the dependency list page. It was previously showing the default sort order to be ascending by vulnerability severity level, yet the actual sort order was descending.
What are the relevant issues numbers?
Screenshots (strongly suggested)
Before change
Sort order icon incorrectly shows ascending order for Severity, when they're actually sorted in descending order:
After change
Sort order icon now correctly shows descending order for Severity:
Caveats
The descending sort order and icon for the default Severity type is correct, however, it now defaults to descending for both the Component name and Packager types, which is probably not ideal:
This has been discussed here and it was decided that this will be addressed in this follow-up issue Add support for multiple default sort orders in dependency list page
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Adam Cohen