Add a feature flag to change maximum text highlight size to 1MB
What does this MR do?
We've recently added a new setting in the gitlab.yml
file called maximum_text_highlight_size_kilobytes
. This prevents any file over the size limit (currently 512kb) from getting syntax highlighting applied to it. This is to prevent extra page loading time because of the syntax highlighter timing out.
After some investigation at #330894 (closed) - we've determined that a very low percentage of files are timing out, and the idea was floated to raise this limit to 1024kb to make a better experience:
This MR adds a feature flag that will let us temporarily change that value to 1MB (and disable it if we have to)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #330894 (closed)