Skip to content

Add a feature flag to change maximum text highlight size to 1MB

What does this MR do?

We've recently added a new setting in the gitlab.yml file called maximum_text_highlight_size_kilobytes. This prevents any file over the size limit (currently 512kb) from getting syntax highlighting applied to it. This is to prevent extra page loading time because of the syntax highlighter timing out.

After some investigation at #330894 (closed) - we've determined that a very low percentage of files are timing out, and the idea was floated to raise this limit to 1024kb to make a better experience:

This MR adds a feature flag that will let us temporarily change that value to 1MB (and disable it if we have to)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #330894 (closed)

Edited by Gary Holtz

Merge request reports