Skip to content

GithubImporter: Fixes merged_by importer when merger user is nil

What does this MR do?

When the user who merged the Github Pull Request was deleted, github API sends nil in the merged_by field. To avoid an exception, when creating the complementary note that mentions the original merger user, fallbacks to 'ghost' in the note.

Related to: #334213 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges

Merge request reports