Skip to content

Draft: Finalize PK conversion for push_event_payloads only for GitLab.com

What does this MR do?

We found that the Database::BatchedBackgroundMigrationWorker is running only for GitLab.com. This mean that even if we though we shipped PK conversion batched migrations for self-managed, they are not being processed, and self-managed instances are not ready to finalize PK conversions in 14.1 - ensure_batched_background_migration_is_finished will be failing for them.

This MR is fixing this problem by:

  1. Updating the existing migration db/post_migrate/20210622041846_finalize_push_event_payloads_bigint_conversion.rb to be executed only on GitLab.com (+ dev and test) environments. This will diverge the database schema between existing self-managed and GitLab.com. New self-managed installations will have the same schema as GitLab.com.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #288005 (closed)

Edited by Krasimir Angelov

Merge request reports