Draft: Cache issuables count for state
What does this MR do?
For the lists of issuables, at group and project level, we use IssuableFinder#count_by_state that performs an expensive COUNT query.
To improve performance, this MR adds the option to cache results at Gitlab::IssuablesCountForState level with a new argument store_in_redis_cache.
This argument is then set as true in IssuablesHelper#issuables_count_for_state, which will attempt to cache the count values for the issuable tabs.
The conditions for the caching are:
- The feature flag
:cached_issuables_state_countis enabled. - A
parentis present (this the group or project defined by the finder). - There are no filters or search terms present.
The expiration time for the cached values is currently set as 10 minutes.
This implementation is being developed behind the FF :cached_issuables_state_count, which is disabled by default.
Screenshots (strongly suggested)
| Issuables count in tabs | COUNT query |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325656 (closed)