Skip to content

Add size-prop to all GlLoadingIcon instances

What does this MR do?

It adds the current GlLoadingIcon's default size to all component instances without a specific size property.

This is in preparation for an MR within @gitlab/ui, which moves the loader's default size from sm to md, and ensures that the current UI stays as-is.

Related links:

Note: This is the regex that was used to search for instances without a size prop:

<gl-loading-icon((?!size)(.|\n))*?\/>

(thanks @pgascouvaillancourt for version 2, which includes multilines)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David Pisek

Merge request reports