Guard Compliance CI evaluation against blank path
What does this MR do?
Guard Compliance CI evaluation against blank configuration path.
This change ensures the Compliance CI template is not evaluated if the compliance pipeline configuration location is blank (i.e. nil and empty string).
The empty string value was caused by a bug in bootstrap-vue library. This bug is addressed in v2.20.0 and will be followed up in gitlab-ui#883 (closed).
How to test
This requires a GitLab Ultimate license to use
- Log in as a group owner
- Navigate to
Group > General Settings - Add a new compliance framework to a group
- Move the cursor to the Compliance pipeline configuration location field but DO NOT enter any value
- Hit
Save - Tag project with the new compliance framework via
Project > General Settings - Run a new pipeline and observe the error
Screenshots (strongly suggested)
| Compliance Configuration | Pipeline Error |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #333306 (closed)
Edited by Tan Le