Fix the migration finalizing push_even_payloads PK conversion
What does this MR do?
With !64577 (merged) we swapped between the integer
and bigin
columns for event_id
. Once it was deployed to GitLab we found there were type mismatch errors like
type of parameter 15 (bigint) does not match that when preparing the plan (integer)
This is because SQL statements in the function body are treated as prepared statements. The query plan for prepared statements is cached for the duration of the session. We need to update the function definition in order to make PostgreSQL to regenerate the plan for the prepared statement. More details here - #288005 (comment 613672553).
This MR updates the migration to update the rename trigger function trigger_07c94931164e
after swapping the columns by executing
"ALTER FUNCTION trigger_07c94931164e RESET ALL
How to verify this fix:
- Run
bundle exec rails db:migrate:down VERSION=20210622041846
. - Open psql session -
gdk psql
. - Insert into
push_event_payloads
, e.g.INSERT INTO push_event_payloads (commit_count, event_id, action, ref_type) VALUES (1, 451, 1, 1)
. - Without closing the sessions, execute the migration -
bundle exec rails db:migrate:up VERSION=20210622041846
. - In the open session, try another insert - e.g.
INSERT INTO push_event_payloads (commit_count, event_id, action, ref_type) VALUES (1, 450, 1, 1)
.
The second INSERT should succeed. Without this fix we will get the above error - "type of parameter 15 (bigint) does not match that when preparing the plan (integer)".
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #288005 (closed)