Skip to content

Fix the migration finalizing push_even_payloads PK conversion

What does this MR do?

With !64577 (merged) we swapped between the integer and bigin columns for event_id. Once it was deployed to GitLab we found there were type mismatch errors like

 type of parameter 15 (bigint) does not match that when preparing the plan (integer)

This is because SQL statements in the function body are treated as prepared statements. The query plan for prepared statements is cached for the duration of the session. We need to update the function definition in order to make PostgreSQL to regenerate the plan for the prepared statement. More details here - #288005 (comment 613672553).

This MR updates the migration to update the rename trigger function trigger_07c94931164e after swapping the columns by executing

"ALTER FUNCTION trigger_07c94931164e RESET ALL

How to verify this fix:

  1. Run bundle exec rails db:migrate:down VERSION=20210622041846.
  2. Open psql session - gdk psql.
  3. Insert into push_event_payloads, e.g. INSERT INTO push_event_payloads (commit_count, event_id, action, ref_type) VALUES (1, 451, 1, 1).
  4. Without closing the sessions, execute the migration - bundle exec rails db:migrate:up VERSION=20210622041846.
  5. In the open session, try another insert - e.g. INSERT INTO push_event_payloads (commit_count, event_id, action, ref_type) VALUES (1, 450, 1, 1).

The second INSERT should succeed. Without this fix we will get the above error - "type of parameter 15 (bigint) does not match that when preparing the plan (integer)".

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #288005 (closed)

Merge request reports