Skip to content

Move project runner controller to settings

What does this MR do?

Move project runner controller to settings

This refactor moves the runner controller to the setting folder to match more closely the menu structure to the project settings.

The motivation for this change is to make space for a future runner controller for projects that are not inside settings.

File locations

Old directory New /settings dir
app/controllers/projects/runners_controller.rb app/controllers/projects/settings/runners_controller.rb
ee/app/controllers/projects/runners_controller.rb ee/app/controllers/projects/settings/runners_controller.rb
app/views/projects/runners/*.html.haml app/views/projects/settings/runners/*.html.haml

Non-backward compatible paths

This change include changes in the Runners URLs: When visited from the project page, URLs have been updated.

Path URL New URL
Project > CI/CD Settings > Runner http://gdk.test:3000/h5bp/html5-boilerplate/-/runners/14 http://gdk.test:3000/h5bp/html5-boilerplate/-/settings/runners/14
Project > CI/CD Settings > Runner > Edit http://gdk.test:3000/h5bp/html5-boilerplate/-/runners/14/edit http://gdk.test:3000/h5bp/html5-boilerplate/-/settings/runners/14/edit

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #19819 (closed)

Edited by Miguel Rincon

Merge request reports