Skip to content

Add basic auth to the API for supported providers

Thomas Mendoza requested to merge tgmachina/gitlab:api-basic-auth into master

What does this MR do?

This MR adds basic auth via supported providers (LDAP, Crowd, Database, etc) to the GitLab API.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

The major performance risk involves repeated, short-interval API calls because the underlying auth provider is called to validate each API request. A parallel MR to enable caching for the Gitlab::Auth.find_with_user_password method could be a solution, but I'd like to discuss that with GitLab devs first.

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Mendoza

Merge request reports