Geo - Fix state value in the lfs_object_registry table

What does this MR do?

Set the state column value to 2 in the lfs_object_registry table for LFS objects that have been successfully synced.

Migration output

  • Up

    == 20210624160455 FixStateColumnInLfsObjectRegistry: migrating ================
    -- transaction_open?()
      -> 0.0000s
    -- exec_query("SELECT COUNT(*) AS count FROM \"lfs_object_registry\" WHERE \"lfs_object_registry\".\"success\" = TRUE")
      -> 0.0962s
    -- exec_query("SELECT \"lfs_object_registry\".\"id\" FROM \"lfs_object_registry\" WHERE \"lfs_object_registry\".\"success\" = TRUE ORDER BY \"lfs_object_registry\".\"id\" ASC LIMIT 1")
      -> 0.0011s
    -- exec_query("SELECT \"lfs_object_registry\".\"id\" FROM \"lfs_object_registry\" WHERE \"lfs_object_registry\".\"id\" >= 4 AND \"lfs_object_registry\".\"success\" = TRUE ORDER BY \"lfs_object_registry\".\"id\" ASC LIMIT 1 OFFSET 1000")
      -> 0.0014s
    -- execute("UPDATE \"lfs_object_registry\" SET \"state\" = 2 WHERE \"lfs_object_registry\".\"id\" >= 4 AND \"lfs_object_registry\".\"id\" < 1026 AND \"lfs_object_registry\".\"success\" = TRUE")
      -> 0.0072s
    
    ...
    
    -- execute("UPDATE \"lfs_object_registry\" SET \"state\" = 2 WHERE \"lfs_object_registry\".\"id\" >= 1799026 AND \"lfs_object_registry\".\"id\" < 1800026 AND \"lfs_object_registry\".\"success\" = TRUE")
      -> 0.0054s
    -- exec_query("SELECT \"lfs_object_registry\".\"id\" FROM \"lfs_object_registry\" WHERE \"lfs_object_registry\".\"id\" >= 1800026 AND \"lfs_object_registry\".\"success\" = TRUE ORDER BY \"lfs_object_registry\".\"id\" ASC LIMIT 1 OFFSET 1000")
      -> 0.0577s
    -- execute("UPDATE \"lfs_object_registry\" SET \"state\" = 2 WHERE \"lfs_object_registry\".\"id\" >= 1800026 AND \"lfs_object_registry\".\"success\" = TRUE")
      -> 0.0425s
    == 20210624160455 FixStateColumnInLfsObjectRegistry: migrated (11.5808s) =======
  • Down

    == 20210624160455 FixStateColumnInLfsObjectRegistry: reverting ================
    == 20210624160455 FixStateColumnInLfsObjectRegistry: reverted (0.0000s) =======

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related issue

Related to #334550 (closed)

Edited by Michael Kozono