Skip to content

Add the initial drawer to the compliance dashboard

Robert Hunt requested to merge 299357-add-a-drawer-to-the-compliance-report into master

What does this MR do?

This MR adds an initial drawer component to the compliance dashboard. This is being added behind the frontend development feature flag :compliance_dashboard_drawer while development is taking place.

This first MR only includes the MR title in the drawer and sets up the opening/closing functionality. Future MR's will add all the other sections and then remove this feature flag and remove all the components duplication.

Setup & testing

This requires a GitLab Ultimate license to use

  1. With the feature flag disabled go to [HOST]/groups/[GROUP]/-/security/compliance_dashboard
  2. Check that MR's are shown, if they aren't then you may need to merge some in the group
  3. Check the MR's data appears and only the individual links are clickable

  1. Enable the feature flag: echo "Feature.enable(:compliance_dashboard_drawer)" | rails c
  2. Go to [HOST]/groups/[GROUP]/-/security/compliance_dashboard
  3. Check that MR's are shown, if they aren't then you may need to merge some in the group
  4. Check the MR's data appears and you can click on an MR row to show the drawer (only shows the MR's title right now)
  5. Check you can close the drawer with the X in the drawer or pressing esc
  6. Check you can open another MR's drawer and also swap between MR's
  7. Check that the MR rows individual links still work as expected

Screenshots (strongly suggested)

Drawer disabled Drawer enabled
Screen_Recording_2021-06-28_at_16.12.41 Screen_Recording_2021-06-28_at_16.09.51

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #299357 (closed)

Edited by Robert Hunt

Merge request reports