Skip to content

Draft: Have StuckCiJobsWorker execute DropPendingWorker

Allison Browne requested to merge ab-refactor-pending-stuck into master

What does this MR do?

In !63314 (comment 605193249) @reprazent suggested:

As far as the StuckCiJobsWorker worker is concerned. If we've hit the ceiling optimizing these queries, I wonder if we could make sure that a failure of 1 of the drop operations doesn't prevent any of the others from running. Perhaps by breaking up the worker? Or is the sequence these are executed important?

This extracts out a Ci::StuckBuilds::DropPendingWorker and Service.

This is pulled off of this Large MR (to be used as reference for what's coming next).

!64643 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Allison Browne

Merge request reports