Skip to content

Bump the sys-filesystem version to prevent errors in System Info

Catalin Irimie requested to merge cat-bump-sys-filesystem into master

What does this MR do?

Updates the sys-filesystem to prevent 500s in Admin::SystemInfoController#show, #22431.

This was fixed by https://github.com/djberg96/sys-filesystem/pull/23/files.

https://my.diffend.io/gems/sys-filesystem/1.1.6/1.1.9

Screenshots (strongly suggested)

Before, 1.1.6:

irb(main):001:0> Sys::Filesystem.method(:mounts)
=> #<Method: Sys::Filesystem.mounts() /usr/local/bundle/gems/sys-filesystem-1.1.6/lib/sys/unix/sys/filesystem.rb:245>
irb(main):002:0> Sys::Filesystem.mounts
/usr/local/bundle/gems/sys-filesystem-1.1.6/lib/sys/unix/sys/filesystem.rb:301:in `mounts': No such file or directory - setmntent (Errno::ENOENT)

After, 1.1.9:

irb(main):001:0> Sys::Filesystem.method(:mounts)
=> #<Method: Sys::Filesystem.mounts() /usr/local/bundle/gems/sys-filesystem-1.1.9/lib/sys/unix/sys/filesystem.rb:242>
irb(main):002:0> Sys::Filesystem.mounts
=>
[#<Sys::Filesystem::Mount:0x00005583c7c12c58
[..]
]

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports