Async job for note + event when creating/updating an EpicIssue link
What does this MR do?
When issue's epic is assigned or changed, this operation is SQL-expensive. We can do part at least a small part of logic asynchronously which saves us some SQL queries:
- creation of system notes - this saves us noticable amount SQL queries
- usage ping metrics update - this is actually pretty cheap, but still no reason not to do it on background if we have the worker
It's questionable whether it's worth to offload system notes creation into an async worker as it adds some extra logic, on the other side I think some services (in this case issue update service) became pretty heavy and expensive. Given the fact that requests should do <100 SQL queries and system notes creation in this case takes 25 queries (overall count including savepoints, commits...), I would say it is still worth it.
Related to #247861 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team