Skip to content

Resolve "Bug: Not showing warning when we don't show the full diff in a merge request"

What does this MR do?

What was happening was that, for example, if our limit files was 1,000 and our diff had 1,500 we would only save 1000 files from gitaly in the database, and when reading them back it wouldn't overflow since it only contains 1,000 files and as such, no warning would be shown. However, it is still overflown, and the warning should be shown.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #332883 (closed)

Edited by Marc Shaw

Merge request reports