Skip to content

Move creation of event outside of mailer

Jan Provaznik requested to merge sdesk_event_update into master

What does this MR do?

Metric events are created for service desk related outgoing emails (added in !63037 (merged)), but to assure that these events are not generated multiple times (when delivery is retried), these events are now created before Notify is called.

Related to #298744 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jan Provaznik

Merge request reports