Increase limit of body fields for evidence
What does this MR do?
This MR increases the limit of the body
field for Vulnerability Finding Evidences. 2048 is a guidance, and not a hard rule, so doubling the allowed field value. This is part of MR #267489
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Database
Migration
== 20210617200551 IncreaseEvidenceBodyLimit: migrating ========================
-- execute("ALTER TABLE vulnerability_finding_evidence_requests\nDROP CONSTRAINT IF EXISTS check_7e37f2d01a\n")
-> 0.0030s
-- execute("ALTER TABLE vulnerability_finding_evidence_responses\nDROP CONSTRAINT IF EXISTS check_76bac0c32b\n")
-> 0.0010s
-- transaction_open?()
-> 0.0000s
-- current_schema()
-> 0.0002s
-- execute("ALTER TABLE vulnerability_finding_evidence_requests\nADD CONSTRAINT check_7e37f2d01a\nCHECK ( char_length(body) <= 4096 )\nNOT VALID;\n")
-> 0.0019s
-- current_schema()
-> 0.0002s
-- execute("ALTER TABLE vulnerability_finding_evidence_requests VALIDATE CONSTRAINT check_7e37f2d01a;")
-> 0.0039s
-- transaction_open?()
-> 0.0000s
-- current_schema()
-> 0.0002s
-- execute("ALTER TABLE vulnerability_finding_evidence_responses\nADD CONSTRAINT check_76bac0c32b\nCHECK ( char_length(body) <= 4096 )\nNOT VALID;\n")
-> 0.0010s
-- current_schema()
-> 0.0002s
-- execute("ALTER TABLE vulnerability_finding_evidence_responses VALIDATE CONSTRAINT check_76bac0c32b;")
-> 0.0030s
== 20210617200551 IncreaseEvidenceBodyLimit: migrated (0.0391s) ===============
Rollback
== 20210617200551 IncreaseEvidenceBodyLimit: reverting ========================
-- execute("ALTER TABLE vulnerability_finding_evidence_requests\nDROP CONSTRAINT IF EXISTS check_7e37f2d01a\n")
-> 0.0015s
-- execute("ALTER TABLE vulnerability_finding_evidence_responses\nDROP CONSTRAINT IF EXISTS check_76bac0c32b\n")
-> 0.0008s
-- transaction_open?()
-> 0.0000s
-- current_schema()
-> 0.0002s
-- execute("ALTER TABLE vulnerability_finding_evidence_requests\nADD CONSTRAINT check_7e37f2d01a\nCHECK ( char_length(body) <= 2048 )\nNOT VALID;\n")
-> 0.0013s
-- current_schema()
-> 0.0002s
-- execute("SET statement_timeout TO 0")
-> 0.0005s
-- execute("ALTER TABLE vulnerability_finding_evidence_requests VALIDATE CONSTRAINT check_7e37f2d01a;")
-> 0.0010s
-- execute("RESET ALL")
-> 0.0006s
-- transaction_open?()
-> 0.0000s
-- current_schema()
-> 0.0002s
-- execute("ALTER TABLE vulnerability_finding_evidence_responses\nADD CONSTRAINT check_76bac0c32b\nCHECK ( char_length(body) <= 2048 )\nNOT VALID;\n")
-> 0.0011s
-- current_schema()
-> 0.0002s
-- execute("ALTER TABLE vulnerability_finding_evidence_responses VALIDATE CONSTRAINT check_76bac0c32b;")
-> 0.0011s
== 20210617200551 IncreaseEvidenceBodyLimit: reverted (0.0333s) ===============
Edited by Jonathan Schafer