Skip to content

Remove disable_composer_callback feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Steve Abrams requested to merge 333587-delete-composer-callback-ff into master

What does this MR do?

Removes the disable_composer_callback feature flag which has been enabled on GitLab.com since 2021-06-17

This feature flag wrapped a callback in the package model that was throwing errors and after investigation looked to be dead code. The feature flag was a safety mechanism to disable it before removing it just in case there was something missed in the investigation.

Now that it has been disabled, the errors have stopped, and there have been no other issues with the related package and Composer code, so the callback is ready to be removed entirely.

References

See this thread and this MR description if you'd like more background and details on why the callback is not needed.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #333587 (closed)

Edited by Steve Abrams

Merge request reports