Skip to content

Customize this page banner shows up when it shouldn't

What does this MR do?

  1. We need to hide the banner on / when it is not on the default setting of projects(even if they haven't dismissed the banner as this would signify a change from the default and the user knows about the feature)
  2. Hide the banner if the user has navigated directly to /dashboard/projects and hasn't dismissed the banner(should only be valid to show on /)

How to reproduce in GDK

  1. Register as a new user.
  2. Navigate to /dashboard/projects (http://127.0.0.1:3000/dashboard/projects) or click on menu and select 'your projects'
  3. Validate Do you want to customize this page? is not shown.
  4. Navigate to / (http://127.0.0.1:3000/) or click GitLab logo in nav bar.
  5. Validate Do you want to customize this page? is shown.
  6. Navigate to http://127.0.0.1:3000/-/profile/preferences or click user dropdown and select Preferences
  7. Set Homepage content to something other than the default and save changes.
  8. Navigate to / (http://127.0.0.1:3000/) or click GitLab logo in nav bar.
  9. Validate Do you want to customize this page? is not shown.

Screenshots (strongly suggested)

See screenshots from original MR

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #333711

Edited by Doug Stull

Merge request reports