Skip to content

Fix too many redirects during Geo check task

Michael Kozono requested to merge mk/fix-geo-http-connection-check into master

What does this MR do?

We've ran into a somewhat similar problem with a customer where they had 5 actual redirects on the primary (sign-in -> auto sign in -> external provider redirects), and we received a RedirectionTooDeep. Testing in the Rails console with a limit: 10 added worked.

Related to #332404 (resolves a similar problem)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports