Skip to content

Add mailgun application settings for receiving email send failures

What does this MR do?

Steps 1 & 2 from this plan

  1. Introduce mailgun_signing_key and mailgun_events_enabled to applications_settings.
  2. Introduce admin integration for instance.

Test locally(GDK)

  1. Navigate to http://127.0.0.1:3000/admin/application_settings/general and find mailgun section.

Screenshots

Screen_Shot_2021-06-17_at_5.21.06_PM

Migration output

Migration

❯ be rails db:migrate
== 20210616185947 AddMailgunSettingsToApplicationSetting: migrating ===========
-- add_column(:application_settings, :encrypted_mailgun_signing_key, :binary)
   -> 0.0058s
-- add_column(:application_settings, :encrypted_mailgun_signing_key_iv, :binary)
   -> 0.0011s
-- add_column(:application_settings, :mailgun_events_enabled, :boolean, {:default=>false, :null=>false})
   -> 0.0042s
== 20210616185947 AddMailgunSettingsToApplicationSetting: migrated (0.0112s) ==

Rollback

❯ be rails db:rollback
== 20210616185947 AddMailgunSettingsToApplicationSetting: reverting ===========
-- remove_column(:application_settings, :mailgun_events_enabled, :boolean, {:default=>false, :null=>false})
   -> 0.0029s
-- remove_column(:application_settings, :encrypted_mailgun_signing_key_iv, :binary)
   -> 0.0010s
-- remove_column(:application_settings, :encrypted_mailgun_signing_key, :binary)
   -> 0.0009s
== 20210616185947 AddMailgunSettingsToApplicationSetting: reverted (0.0071s) ==

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #333562

Edited by Doug Stull

Merge request reports