Add mailgun application settings for receiving email send failures
requested to merge 333562-setup-gitlab-mailgun-endpoint-for-syncing-bounced-invite-emails into master
What does this MR do?
Steps 1 & 2 from this plan
- Introduce
mailgun_signing_key
andmailgun_events_enabled
toapplications_settings
. - Introduce admin integration for instance.
- Copies heavily for inspiration from !60710 (merged) and !60385 (merged)
Test locally(GDK)
- Navigate to http://127.0.0.1:3000/admin/application_settings/general and find
mailgun
section.
Screenshots
Migration output
Migration
❯ be rails db:migrate
== 20210616185947 AddMailgunSettingsToApplicationSetting: migrating ===========
-- add_column(:application_settings, :encrypted_mailgun_signing_key, :binary)
-> 0.0058s
-- add_column(:application_settings, :encrypted_mailgun_signing_key_iv, :binary)
-> 0.0011s
-- add_column(:application_settings, :mailgun_events_enabled, :boolean, {:default=>false, :null=>false})
-> 0.0042s
== 20210616185947 AddMailgunSettingsToApplicationSetting: migrated (0.0112s) ==
Rollback
❯ be rails db:rollback
== 20210616185947 AddMailgunSettingsToApplicationSetting: reverting ===========
-- remove_column(:application_settings, :mailgun_events_enabled, :boolean, {:default=>false, :null=>false})
-> 0.0029s
-- remove_column(:application_settings, :encrypted_mailgun_signing_key_iv, :binary)
-> 0.0010s
-- remove_column(:application_settings, :encrypted_mailgun_signing_key, :binary)
-> 0.0009s
== 20210616185947 AddMailgunSettingsToApplicationSetting: reverted (0.0071s) ==
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #333562
Edited by Doug Stull