Skip to content

Drop index_ci_builds_on_protected index

Max Orefice requested to merge mo-remove-ci-build-protected-index into master

Ref: #333814 (closed)

What does this MR do?

This MR removes index_ci_builds_on_protected index which is no longer needed.

Database review

Migration output

$ bin/rails db:migrate
== 20210616154808 RemoveCiBuildProtectedIndex: migrating ======================
-- transaction_open?()
   -> 0.0000s
-- index_exists?(:ci_builds, :protected, {:name=>"index_ci_builds_on_protected", :algorithm=>:concurrently})
   -> 0.0118s
-- execute("SET statement_timeout TO 0")
   -> 0.0005s
-- remove_index(:ci_builds, {:name=>"index_ci_builds_on_protected", :algorithm=>:concurrently, :column=>:protected})
   -> 0.0136s
-- execute("RESET ALL")
   -> 0.0006s
== 20210616154808 RemoveCiBuildProtectedIndex: migrated (0.0273s) =============

Migration rollback

$ bin/rails db:rollback
== 20210616154808 RemoveCiBuildProtectedIndex: reverting ======================
-- transaction_open?()
   -> 0.0000s
-- index_exists?(:ci_builds, :protected, {:name=>"index_ci_builds_on_protected", :algorithm=>:concurrently})
   -> 0.0091s
-- execute("SET statement_timeout TO 0")
   -> 0.0005s
-- add_index(:ci_builds, :protected, {:name=>"index_ci_builds_on_protected", :algorithm=>:concurrently})
   -> 0.0096s
-- execute("RESET ALL")
   -> 0.0005s
== 20210616154808 RemoveCiBuildProtectedIndex: reverted (0.0205s) =============

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports