Skip to content

Resolve "Geo: sync disabled wikis"

Valery Sizov requested to merge 6142-geo-sync-disabled-wikis into master

What does this MR do?

It will affect only new Geo setups. If wiki was marked as successfully synced it will stay as is. For gitlab.com this means we might want to implement and deploy https://gitlab.com/gitlab-org/gitlab-ee/issues/5484 afterward.

Are there points in the code the reviewer needs to double check?

  • I have not touched SiteStatistic model just because we have to aim to keep every MR as small as possible. Ideally, I think we need to delete wiki_counts from that table and rename repository_counts to projects counts. So let's do that as a follow-up issue.

  • The second thing that is omitted here is that frontend still uses deprecated wiki_counts and repositories_counts. I would also consider this as a follow-up issue.

  • I have kept metrics untouched https://gitlab.com/gitlab-org/gitlab-ee/blob/master/ee/app/models/geo_node_status.rb#L26 I think we need to delete repositories_count and wikis_count and use projects_count. I think that will aslso require changing dashboard configuration so let's keep it as a follow-up issue as well.

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Conform by the database guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-and-qa manual pipeline job)
  • Follow-up issue in gitlab-qa to prevent regressions in the future
  • Create MR with the changes that we reverted here for the sake of backward compatibility

What are the relevant issue numbers?

Closes #6142 (closed) and https://gitlab.com/gitlab-org/gitlab-ee/issues/7161

Edited by Valery Sizov

Merge request reports