Test framework update: allow tests to click elements without waiting for page to fully load
What does this MR do?
I've added a kwarg hash element check to click_element
and find_element
so that I can write a test that does not wait for the page to fully load before interacting with it. I needed to do this because when using the pipeline editor page without any runners configured there is a pipeline status spinner that never finishes loading and prevents the wait_for_requests
method from allowing the tests to interact with the elements on the page that are loaded.
Unblocks !63811 (merged)
Screenshots (strongly suggested)
Note the pipeline status spinner in this movie Screen_Recording_2021-05-21_at_14.53.09
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
If it succeeds review and qa there should be no worries.
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team