Skip to content

Migrate environment header to vue

Savas Vedova requested to merge 254258-replace-bootstrap-modal into master

What does this MR do?

As part of the Pajamas migration, this #254258 (closed) is about using a vue modal for the stop button in the Environments detail page. Since the whole page was written in HAML, I decided to break it down and migrate the header part to vue.

This MR also removes a few QA tests as now we can write unit tests in the frontend to test the functionality.

Screenshots (strongly suggested)

Here's a screenshot that displays the two header bars. The one in red is HAML and the one in green is Vue. The buttons are slightly different but that should be because we now use our own component library directly instead of relying on css classes. This screenshot will include all functionalities, so if you test locally some of the buttons may be missing due to permissions.

Screenshot_2021-06-15_at_22.55.37

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #254258 (closed)

Edited by Savas Vedova

Merge request reports

Loading