Skip to content

Fix user permissions for pipeline graph

Payton Burdette requested to merge 332268-fix-permissions-for-manual-job into master

What does this MR do?

This MR ensures user permissions are taken into account on the pipeline graph when performing a manual action.

How to test

  • Create a pipeline with a stage of manual jobs
  • Impersonate a user on your project with reporter access
  • View the pipeline

Related to: #332268 (closed)

Screenshots (strongly suggested)

Before

A user with reporter access could see the play button to run manual jobs. They were not allowed on the BE to perform the action but we still showed them the button

Screen_Shot_2021-06-15_at_2.18.05_PM

After

Now only a user with updatePipeline permissions can see the action button.

Screen_Shot_2021-06-15_at_2.25.16_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #332268 (closed)

Edited by Payton Burdette

Merge request reports