Fix Performance Bar, Sentry and Jira Connect App on relative urls
What does this MR do?
We are currently setting a global variable __webpack_public_path__ in
a global JavaScript function that gets the value from the Gon object.
This just happens in the page specific JavaScript. The value from this
variable is used for e.g. dynamically loading JavaScript assets like the
WebIDE or parts of the PerformanceBar.
In order to add that functionality to the other entry points
(Performance Bar, Sentry and Jira Connect App), we have to add the
import of app/assets/javascripts/webpack.js to them.
Unfortunately we cannot move this to a global helper because setting
__webpack_public_path__ needs to happen within the webpack context.
In order raise awareness we are adding a note to the webpack config.
This can potentially be resolved in WebPack 5 as they have an auto
option for publicPath
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #323051 (closed)