Update test_file_finder and Faraday
What does this MR do?
This updates our Gemfile to use a newer version of test_file_finder. That new version doesn't pin the Faraday version to 1.0.1, so we'll be able to upgrade Faraday in this project once the change is merged.
Updates to test_file_finder
Are fairly minimal. All we changed in tff is changing the faraday dependency to be pinned to the major instead of the minor. It was requested by GitLab team member, and the test_file_finder project has no reason to run an older version of faraday intentionally.
Updates to faraday
https://my.diffend.io/gems/faraday/1.0.1/1.4.2
The important part is https://github.com/lostisland/faraday/pull/1276 to fix #328420 (closed). We use Faraday in quite a lot of places, for omniauth, danger, elasticsearch, azure-*, octokit and probably a few others. The changes seem relatively minor from the diff and changelog, mostly around splitting adapters, here's a note from the changelog:
This is also the first release with a previously "included" adapter (Net::HTTP) being isolated into a separate gem
🎊 ! The new adapter is added to Faraday as a dependency for now, so that means full backwards-compatibility, but just to be safe be careful when upgrading!
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team