Skip to content

Don't compare array orders when FF disabled

What does this MR do?

Fix for broken master #333513 (closed).

Seems to be the related MR: !62983 (merged).

I think the assumption in the test is that when sort_dependency_vulnerabilities flag is disabled, the sort should be min -> high.

It seems that when the flag is disabled the vulnerabilities are left unsorted in a non-deterministic order. https://gitlab.com/gitlab-org/gitlab/-/blob/1e95f574669eee7257dfd278c3dba8ecbab3dc3d/ee/app/services/security/dependency_list_service.rb#L58

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #333513 (closed)

Edited by Sean Arnold

Merge request reports