Remove the container expiration loopless feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]
⛵ Context
Cleanup policies are executed by background jobs.
Those jobs basically orchestrate several container registry API calls to locate and destroy tags (of container images) that are not kept by the policy.
Because this logic can be slow and eat a lot of resources on the backend side, we implemented limits in !40740 (merged).
During that time, we noticed that we had a not so trivial SQL query to run to get all the policies that need to be executed now and go through them to mark the related container images. At that time, we simply solved that problem by using .each_batch.
The problem is that this query is going to fetch more policies because we're rolling out cleanup policies for projects pre 12.8.
In other words, that loop will not scale well. That is exactly issue where we discussed an implementation that would not use a loop. ("loop" version vs "loopless" version)
This change has been implemented behind a feature flag to be able to toggle between those versions.
The "loopless" version has been running on gitlab.com successfully for a week now. We can thus remove the feature flag and the code associated with the "loop" version.
Rollout issue: #325273 (closed).
There is no documentation changes to this because:
- this actually more of a refactoring that anything. The result is actually the same: the proper policies are properly executed.
- this feature flag was a feature flag within a feature flag. So the "loopless" is still behind a feature flag.
🔬 What does this MR do?
- Remove the
container_registry_expiration_policies_looplessfeature flag - Remove or update the related specs.
🖼 Screenshots (strongly suggested)
n / a
🔱 Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
- [-] I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
- [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team