Skip to content

Advanced Search Settings page does not load if the ES url is unreachable

Dmitry Gruzd requested to merge 331513-fix-es-settings into master

What does this MR do?

This MR fixes the 500 error when a user provides an incorrect (inaccessible) Elasticsearch URL for the Advanced Search integration.

#331513 (closed)

Steps to reproduce

  1. Open the rails console
  2. Set the elasticsesarch_url to an impossible IP ApplicationSetting.update(elasticsearch_url: "http://192.0.2.0:9200")
  3. Open the Admin UI - Settings - Advanced Search Settings page
  4. Verify it takes awhile to load then eventually times out and throws an error

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #331513 (closed)

Edited by Dmitry Gruzd

Merge request reports