Skip to content

Update queryToObject to replace plus with spaces

Miguel Rincon requested to merge mrincon-support-plus-as-spaces into master

What does this MR do?

Update queryToObject to replace plus with spaces

This change makes queryToObject replace plus symbols ("+") with spaces when parsing URL queries into objects, it sets a backward compatible option wherever is used.

Before

?search=a+b became { search: 'a+b' }

After

?search=a+b becomes { search: 'a b' }

Screenshots (strongly suggested)

N/A

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports