Skip to content

DevOps Adoption change add groups to dropdown

What does this MR do?

This MR replaces the modal used to enable / disable devops adoption namespaces with a dropdown. This is a far more performant and scalable solution.

The dropdown displays a maximum of 20 records at a time i.e. the API request will fetch 20 groups based on the search term, and we'll first filter out already enabled groups from the list before displaying the remaining groups in the dropdown.

A 500ms buffer / delay has been implemented between typing and searching for results. This prevents searching on every keystroke.

Once a group is enabled, it will automatically be removed from the dropdown.

The instance level and group level feature have corresponding copy i.e. group on instance level and sub-group on group level.

Screenshots (strongly suggested)

Mobile Desktop With results No results Disabled In action
Screenshot_2021-06-14_at_11.48.54 Screenshot_2021-06-14_at_11.49.44 Screenshot_2021-06-14_at_11.50.15 Screenshot_2021-06-14_at_11.50.27 Screenshot_2021-06-14_at_11.50.45 Screen_Recording_2021-06-14_at_11.53.04

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #329445 (closed) #333231 (closed)

Edited by Martin Wortschack

Merge request reports

Loading