Draft: Introduce Better Pipeline Processing [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This change should prevent duplicate pipelines from being created when a developer pushes to a branch that is part of an open merge request.
To do this, we no-op the BaseHooksService#create_pipelines method if we detect that there are open merge requests with a source branch matching the push ref.
The original intent of this change is specifically to prevent duplicate pipelines, described in #300146. Further discussion with the CI team #325780 (comment 567959101) led to iteration on the proposal into how this change is built today. If you click the link to read the discussion, it is recommended you start with the linked comment and continue that thread, as the issue and discussion is quite large.
More work related to this effort can be found in the related epic &6044
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team