Draft: Update LabelFinder to use index more efficiently
What does this MR do?
In !61648 (comment 594987131), @dskim_gitlab made the observation that we should be able to use the index more efficiently when querying labels:
What do you think about specifying
project_id IS NULL
andgroup_id IS NULL
when queryinggroup_id
orproject_id
to utilize existing unique index? It seems thatgroup_id
andproject_id
are mutually exclusive as far as I can tell so it shouldn't change any underlying behavior, but I'm not sure if I missed anything.
This MR makes that optimization.
See also !61648 (comment 596152850) and !61648 (comment 596162004) for additional observations.
Related to #339349
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team