Skip to content

Draft: Update LabelFinder to use index more efficiently

Brett Walker requested to merge bw-label-finder-tweak into master

What does this MR do?

In !61648 (comment 594987131), @dskim_gitlab made the observation that we should be able to use the index more efficiently when querying labels:

What do you think about specifying project_id IS NULL and group_id IS NULL when querying group_id or project_id to utilize existing unique index? It seems that group_id and project_id are mutually exclusive as far as I can tell so it shouldn't change any underlying behavior, but I'm not sure if I missed anything.

This MR makes that optimization.

See also !61648 (comment 596152850) and !61648 (comment 596162004) for additional observations.

Related to #339349

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Brett Walker

Merge request reports