Skip to content

fix: VulnerabilityFinding equality should exclude other record types

What does this MR do?

fix: vulnerability_findings equality should exclude other record types

Our previous comparison between finding records did not properly check the class type to ensure non-finding records are properly excluded. This can occur when multiple records are created within a transaction (such as Vulnerabilities::CreateService and a simple Array#uniq check is performed.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lucas Charles

Merge request reports