Add epic's note system_note_meta to Import/Export
What does this MR do?
This MR adds system_note_metadata
relation to epic's notes in order to accurately migrate system notes of an epic (e.g. when epic is related to another epic, a system note is created). This MR also:
- Updates both Import/Export and Bulk Import codebase tests, as both features shared ndjson import/export behaviour
- Moves
epics.ndjson.gz
file toee/spec/fixtures
as epics are EE feature - Updates ndjson fixtures to include epics with notes that have system_note_metadata
Mentions #323580 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %14.0
assigned to @georgekoltsov
marked the checklist item I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) as completed
marked the checklist item I have added/updated documentation, or it's not needed. (Is documentation required?) as completed
marked the checklist item I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) as completed
marked the checklist item I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) as completed
marked the checklist item I have self-reviewed this MR per code review guidelines. as completed
marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed
marked the checklist item I have followed the style guides. as completed
marked the checklist item This change is backwards compatible across updates, or this does not apply. as completed
added backend devopsmanage featureaddition sectiondev + 1 deleted label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Alishan 'Ali' Ladhani ( @ali-gitlab
) (UTC-4, 5 hours behind@georgekoltsov
)Bob Van Landuyt ( @reprazent
) (UTC+2, 1 hour ahead of@georgekoltsov
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Bob Van Landuyt
@kassio may I ask you to have a look at this change? thanks!
added 1 commit
- ca32a0f9 - Add epic's note system_note_meta to import/export
requested review from @kassio
removed review request for @kassio
@reprazent may I ask you to do backend maintainer review of this change? Thanks
requested review from @reprazent
- Resolved by Bob Van Landuyt
enabled an automatic merge when the pipeline for f277c2c4 succeeds
Thank you @georgekoltsov. I like this kind of change
(!63551 (comment 597686107)).mentioned in commit 4756edbe
mentioned in issue gitlab-com/gl-infra/scalability#1129
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!39 (merged)
added releasedpublished label and removed releasedcandidate label
added SOX Reviewed typefeature labels
added groupimport and integrate label and removed 1 deleted label