Skip to content

Styling the fly-out menus [RUN AS-IF-FOSS]

Denys Mishunov requested to merge 322680-fly-out-menus into master

What does this MR do?

Styles the fly-out menus in the left sidepanel together with updating some templates to match the refctoring and provide the needed CSS classes. The main changes:

  • Unified the HTML markup in the templates for the menus and sub-menus
  • Added the .has-sub-items CSS class to those topo-level menus that have the sub-items. This is used to style the flyouts differently
  • Improved the top offset calculation for the fly-out menus
  • Actual styling of the fly-out menus

To smoke test in the browser, you will need to either enable or disable the feature flag:

  gitlab git:(322680-contextual-header-styling)  rails c
...
[1] pry(main)> Feature.enable(:sidebar_refactor, User.find_by_username('root'))

Screenshots (strongly suggested)

Without the FF With the FF
Expanded with sub-items Screenshot_2021-06-10_at_16.28.15 Screenshot_2021-06-10_at_16.26.58
Expanded without sub-items Screenshot_2021-06-10_at_16.28.29 Screenshot_2021-06-10_at_16.27.20
Collapsed with sub-items Screenshot_2021-06-10_at_16.28.36 Screenshot_2021-06-10_at_16.27.05
Collapsed without sub-items Screenshot_2021-06-10_at_16.28.42 Screenshot_2021-06-10_at_16.27.13

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #322680 (closed)

Edited by David O'Regan

Merge request reports

Loading