Skip to content

Allow setting of blank string for terms & conditions

Max Woolf requested to merge 35923-blank-terms-allowed into master

What does this MR do?

  • Allows setting a blank string for terms and conditions as long as terms are being enforced.

How to test

  • Go to Admin -> Settings -> General
  • Enter some terms and conditions, attempt to delete them. This should succeed.
  • Enter some terms and conditions, check the box for enforcement.
  • Attempt to delete those terms and conditions, it should not delete the T&C text.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #35923

Merge request reports