Migrate board label select to Vue[RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This change affects the Epic and Issues boards creation/edit form.
A small MVC for: #292103 (closed). Our aim here is to do away with label_select/base.vue
as it was only used in a single place i.e. the board_scope.vue
component. In this effort we aim to re-use the new label_select_vue
component which is used more widely in the application.
Screenshots (strongly suggested)
Before | After |
---|---|
How to test:
Issues
- Navigate to Issues > Boards
- Either select "Edit Board" or "Create new board"
- See label select inside the board scope form
Epics
- Enable Epic Boards feature flag
echo "Feature.enable(:epic_boards)" | rails c
- navigate to Epics > Boards
- Either select "Edit Board" or "Create new board"
- See label select inside the board scope form
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team