Skip to content

Fix escaping characters in authors name for "Pending Comments" dropdown

Ghost User requested to merge (removed):gmain-pending-comment-escape-fix into master

What does this MR do?

This MR fixes issue #301149 (closed). The issue was that the "Pending Comments" popup for merge request reviews would escape any special characters in the authors name. This MR changes the call to sprintf to not escape characters in the authors name.

Screenshots (strongly suggested)

Before: Screenshot_from_2021-06-05_14-56-32

After: Screenshot_from_2021-06-05_15-09-21

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

No risks should be associated with this MR. If the character is possible to be in the author's name, it should not be escaped and displayed as is.

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ghost User

Merge request reports