What does this MR do?
As explained in #329441 (closed), there is a ~bug in RackAttack related to authentication detection: A git client uses basic authentication for cloning a repository. However, this form of authentication was incorrectly detected as unauthenticated. Therefore, when the rate limit was exceeded, the IP was blocked (common if unauthenticated) instead of correctly blocking the corresponding user (common if authenticated).
This MR extends Gitlab::Auth::RequestAuthenticator and Gitlab::Auth::AuthFinders to correctly detect the following forms of basic authentication as well:
<username>:<lfs_token><username>:<personal_access_token><username>:<password>
@gitlab-com/gl-security/appsec This MR is related to security.
Solves #329441 (closed)
/cc @bufferoverflow
Scenarios
| Request | Before MR | After MR |
|---|---|---|
Request: POST /user1/p2.git/git-upload-pack/with HTTP_AUTHORIZATION:
|
RackAttack correctly detects request as unauthenticated |
RackAttack correctly detects request as unauthenticated |
Request: POST /user1/p2.git/git-upload-pack/with HTTP_AUTHORIZATION: <username>:<lfs_token>
|
RackAttack incorrectly detects request as unauthenticated |
RackAttack correctly detects request as authenticated |
Request: POST /user1/p2.git/git-upload-pack/with HTTP_AUTHORIZATION: <username>:<personal_access_token>
|
RackAttack incorrectly detects request as unauthenticated |
RackAttack correctly detects request as authenticated |
Request: POST /user1/p2.git/git-upload-pack/with HTTP_AUTHORIZATION: <username>:<password>
|
RackAttack incorrectly detects request as unauthenticated |
RackAttack correctly detects request as authenticated |
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team