Skip to content

Draft: Deliver DAST on-demand secrets to builds

What does this MR do?

this merge request builds on the work in !62986 (closed) both by allowing dast secret variables to be delivered to dast ci jobs with yaml configuration that references profiles and by moving variable association to the database.

Example

when you define the variable DAST_SITE_PROFILE or DAST_SCANNER_PROFILE in a job as part of the dast stage in the .gitlab.yml we will look up those records in the database by name and add the calculated variables to the job using DastSiteProfile#ci_variables, DastSiteProfile#secret_ci_variables and DastScannerProfile#ci_variables.

stages:
  - dast
  - test
dast:
  stage: dast
  variables:
    DAST_SITE_PROFILE: site-profile-name
    DAST_SCANNER_PROFILE: scanner-profile-name
  script:
    - env

Why?

we want to give customers the ability to use dast profiles in yaml in order to simplify the configuration of DAST for customers.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Philip Cunningham

Merge request reports