Skip to content

Remove `BuildsEmailService` records from `services` table

Luke Duncalfe requested to merge 331064-remove-BuildsEmail-integration into master

What does this MR do?

Records in the services table with type values of "BuildsEmailService" were migrated to be "PipelinesEmailService" in 12dd5ac2. The migration skipped migrating a "BuildsEmailService" record if its project already had a "PipelinesEmailService".

That commit also deleted the corresponding spec for the BuildsEmailService model and added a comment that the model could be removed in 9.1.

There are still 305 BuildsEmailService records in the GitLab.com database.

This MR:

  1. Deletes records in the services table with type of "BuildsEmailService".
  2. Deletes the model (which was recently renamed to Integrations::BuildsEmail in c1867b98)

Migration output

Up

This DELETE statement executes in 437.351 ms on #database-lab.

== 20210603222333 RemoveBuildsEmailServiceFromServices: migrating =============
-- execute("DELETE from services WHERE type = 'BuildsEmailService'")
   -> 0.0038s
== 20210603222333 RemoveBuildsEmailServiceFromServices: migrated (0.0039s) ====

Down

Note that this is a no-op:

== 20210603222333 RemoveBuildsEmailServiceFromServices: reverting =============
== 20210603222333 RemoveBuildsEmailServiceFromServices: reverted (0.0000s) ====

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #331064 (closed)

Edited by Luke Duncalfe

Merge request reports