Skip to content

Add unscoped_issue_list_api app setting

What does this MR do?

Initial review already done in a confidential MR https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/1399

unscoped_issue_list_api application setting is added. true by defauls so it's not a breaking change. Setting this one to false will give an error on GET /api/v4/issues_statistics?scope=all and GET /api/v4/issues?scope=all if no additional filtering is provided. e.g. assignee_id, assignee_username.

Currently in gitlab.com /api/v4/issues_statistics?scope=all timeouts.

DB Migration

UP

== 20210531200126 AddUnscopedIssueListApiToApplicationSettings: migrating =====
-- add_column(:application_settings, :unscoped_issue_list_api, :boolean, {:null=>false, :default=>true})
   -> 0.0043s
== 20210531200126 AddUnscopedIssueListApiToApplicationSettings: migrated (0.0126s)

DOWN

== 20210531200126 AddUnscopedIssueListApiToApplicationSettings: reverting =====
-- remove_column(:application_settings, :unscoped_issue_list_api)
   -> 0.0021s
== 20210531200126 AddUnscopedIssueListApiToApplicationSettings: reverted (0.0104s)

Screenshots (strongly suggested)

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #330519

Edited by Mario Celi

Merge request reports