Enable load balancing for BuildQueueWorker [RUN ALL RSPEC] [RUN AS-IF-FOSS]

changed milestone to %14.0

added Category:Cloud Connector Category:Continuous Integration auto updated backend cloud connectoractive devopsverify groupcloud connector priority2 sectionops severity2 workflowin dev labels

assigned to @alipniagov

changed title from Add data_consistency for BuildQueueWorker to Add data_consistency for BuildQueueWorker [RUN ALL RSPEC] [RUN AS-IF-FOSS]

added feature flag label

2 Messages

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS] (we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
backend	Brett Walker (`@digitalmoksha`) (UTC-5, 8 hours behind `@alipniagov`)	Sean McGivern (`@smcgivern`) (UTC+1, 2 hours behind `@alipniagov`)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in issue #332586 (closed)

added 1 commit

682f7805 - Add data_consistency for BuildQueueWorker

Compare with previous version

added featureenhancement label

added typefeature label

marked the checklist item I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) as completed

marked the checklist item I have tested this MR in all supported browsers, or it's not needed. as completed

marked the checklist item I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed. as completed

added 1 commit

042d4531 - Add data_consistency for BuildQueueWorker

Compare with previous version

changed title from Add data_consistency for BuildQueueWorker [RUN ALL RSPEC] [RUN AS-IF-FOSS] to Enable load balancing for BuildQueueWorker [RUN ALL RSPEC] [RUN AS-IF-FOSS]

changed the description

added 45 commits

042d4531...7b06f6bc - 44 commits from branch master
52884cde - Add data_consistency for BuildQueueWorker

Compare with previous version

I can't test in GDK with LB enabled.

I do export ENABLE_LOAD_BALANCING_FOR_SIDEKIQ="true"
My config:

development:
  adapter: postgresql
  encoding: unicode
  database: gitlabhq_development
  host: /Users/lipton/dev/gitlab/gitlab-development-kit/postgresql
  port: 5432
  pool: 10
  prepared_statements: false
  variables:
    statement_timeout: 120s
  load_balancing:
    hosts:
      - /Users/lipton/dev/gitlab/gitlab-development-kit/postgresql

I receive exception:

Puma caught this error: undefined method `delete' for nil:NilClass (NoMethodError)
/Users/lipton/.asdf/installs/ruby/2.7.2/lib/ruby/gems/2.7.0/gems/activerecord-6.1.3.2/lib/active_record/connection_adapters/abstract/connection_pool.rb:448:in `release_connection'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host.rb:10:in `release_connection'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host.rb:204:in `query_and_release'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host.rb:139:in `replication_lag_time'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host.rb:110:in `replication_lag_below_threshold?'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host.rb:106:in `replica_is_up_to_date?'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host.rb:97:in `refresh_status'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host.rb:72:in `online?'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host_list.rb:80:in `block (2 levels) in next_host'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host_list.rb:76:in `loop'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host_list.rb:76:in `block in next_host'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host_list.rb:71:in `synchronize'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host_list.rb:71:in `next_host'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/host_list.rb:54:in `next'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/load_balancer.rb:121:in `host'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/load_balancer.rb:34:in `read'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/connection_proxy.rb:93:in `read_using_load_balancer'
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/connection_proxy.rb:46:in `select_all'
/Users/lipton/.asdf/installs/ruby/2.7.2/lib/ruby/gems/2.7.0/gems/activerecord-6.1.3.2/lib/active_record/querying.rb:47:in `find_by_sql'
/Users/lipton/.asdf/installs/ruby/2.7.2/lib/ruby/gems/2.7.0/gems/bullet-6.1.3/lib/bullet/active_record61.rb:19:in `find_by_sql'